Re: [libvirt] [PATCH 7/7] virsh: use new virNodeDeviceDetachFlags

The virsh nodedev-detach command has a new --driver option. If it's given virsh will attempt to use the new virNodeDeviceDetachFlags API instead of virNodeDeviceDettach. Validation of the driver name string is left to the hypervisor (qemu accepts "kvm" or "vfio". The only other hypervisor that implements these functions is xen, and it only accepts NULL). --- tools/virsh-nodedev.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-)

- /* Yes, our public API is misspelled. At least virsh can accept - * either spelling. */ - if (virNodeDeviceDettach(device) == 0) { - vshPrint(ctl, _("Device %s detached\n"), name); + if (driverName) { + /* we must use the newer API that accepts a driverName */ + if (virNodeDeviceDetachFlags(device, driverName, 0) < 0) + ret = false; } else { - vshError(ctl, _("Failed to detach device %s"), name); - ret = false; + /* Yes, our (old) public API is misspelled. At least virsh + * can accept either spelling. */ + if (virNodeDeviceDettach(device) < 0) + ret = false;