Re: [libvirt] [PATCH 2/2] test: genericxml2xml: test graphics listen= compat

* Add a test for listen=XXX and <listen address=YYY/> collision error * Add an explicit test for listen=XXX duplicated to <listen address=XXX/>   We implicitly test it elsewhere but I figure it's better to be explicit,   and this test case can be extended in the future for additional listen   back compat if/when we support <listen type='socket'/> syntax --- The latter test case I added to try and exercise the potential crash that Jan pointed out here: https://www.redhat.com/archives/libvir-list/2016-April/msg00241.html That patch was fixed before committing but I was still curious... the test case doesn't tickle the crash? STREQ_NULLABLE seems to avoid it somehow for address=NULL, yet if I try to printf address->address it understandably crashes. Oh well :)  ...eneric-graphics-listen-back-compat-mismatch.xml | 30 ++++++++++++++++++++++  .../generic-graphics-listen-back-compat.xml        | 28 ++++++++++++++++++++  .../generic-graphics-listen-back-compat.xml        | 30 ++++++++++++++++++++++  tests/genericxml2xmltest.c                         | 16 ++++++++----  4 files changed, 99 insertions(+), 5 deletions(-)  create mode 100644 tests/genericxml2xmlindata/generic-graphics-listen-back-compat-mismatch.xml  create mode 100644 tests/genericxml2xmlindata/generic-graphics-listen-back-compat.xml  create mode 100644 tests/genericxml2xmloutdata/generic-graphics-listen-back-compat.xml