Re: [libvirt] [PATCH v2 1/3] qemu_domain: simplify non-VFIO memLockLimit calc for PPC64
On Sun, Mar 03, 2019 at 10:23:12AM -0300, Daniel Henrique Barboza wrote:
passthroughLimit is being calculated even if usesVFIO is false.
After that, a if/else conditional is used to check if we're going
to sum it up with baseLimit.
This patch initializes passthroughLimit to zero and always
return memKB = baseLimit + passthroughLimit. The conditional
is then used to calculate passthroughLimit if usesVFIO is true.
This results in some cycles spared for the usesVFIO=false
scenario, but the real motivation is to make the code simpler
to add an alternative passthroughLimit formula for NVLink2
passthrough.
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
ACK to the idea, but looking at the number of lines of the PPC64 arch specific
logic (I know commentaries mostly), I think it deserves a separate helper to
enhance the readability.
Erik