On Tue, Oct 15, 2024 at 01:38:12PM +0200, Peter Krempa wrote:
On Tue, Oct 15, 2024 at 12:19:20 +0100, Daniel P. Berrangé wrote:
The polkit code does not have a build time dependancy on any system headers or libraries. It can be safely enabled on any non-Windows platform.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- meson.build | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/meson.build b/meson.build index 5eb3f24181..2ce8fac4a1 100644 --- a/meson.build +++ b/meson.build @@ -1433,11 +1433,6 @@ endif if not get_option('polkit').disabled() polkit_enable = true
- if get_option('polkit').auto() - pkcheck_prog = find_program('pkcheck', required: false, dirs: libvirt_sbin_path) - polkit_enable = pkcheck_prog.found() - endif
So while this doesn't have build-time problems this will change the default authentication method for the daemon sockets for builds in absence of polkit.
Is this intended side effect? If yes you should mention it in the commit message as well as in the NEWS.rst file. Historically we added a "Packaging changes" section for that.
Oh, I forgot that we re-wrote the default config file auth scheme based on this test. While polkit is available for macOS/FreeBSD, I don't really want to force enable it by default, so I think this patch is not good. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|