Re: [libvirt] [PATCH v3 1/4] util: new function virFileLength()
On 11/29/2016 02:47 PM, Eric Blake wrote:
On 11/29/2016 01:23 PM, Laine Stump wrote:
> This new function just calls fstat() (if provided with a valid fd) or
> stat() (if fd is -1) and returns st_size (or -1 if there is an
> error). We may decide we want this function to be more complex, and
> handle things like block devices - this is a placeholder (that works)
> for any more complicated function.
> ---
> Changes from V2:
>
> * add fd arg and use it to optionally call fstat() instead of stat.
> * return -1 unless it is a "regular file" (i.e. not a block device).
>
> Is this what you were thinking of Eric?
Yep!
ACK
Thanks! With that ACK, the series is ACKed.
This is the last piece of the "Use PCIe instead of legacy PCI on
machinetypes with a PCIe root bus" that hasn't been pushed. DV already
cut RV1 for the next release, but allowed that it seems innocuous enough
to push these patches before rc2 (thus putting the entire feature into a
single release, rather than part of it):
https://www.redhat.com/archives/libvir-list/2016-November/msg01420.html
so I'm going to push the seriestoday (RC2 will be cut tomorrow)