On Wed, 2021-02-03 at 10:50 -0500, Laine Stump wrote:
On 2/3/21 5:46 AM, Andrea Bolognani wrote:
You could also replace the existing
%define with_netcf 0
that appears earlier in the file with
%define with_netcf 0%{!?_without_netcf:1}
and rewrite this version check with
%if 0%{?fedora} > 33 || %{?rhel} > 8 %define with_netcf 0 %endif
instead. This would keep the version check simpler.
I thought about that, but it would make the default be "enabled", and I want the default to be "disabled".
In name only, given that you'd override it for most platforms later. Alternatively, something like %if 0%{?fedora} > 33 || %{?rhel} > 8 %define with_netcf 0 %else %define with_netcf 0%{!?_without_netcf:1} %endif would work too. But, so does your current version, so feel free to just pick up Dan's R-b and push the patch as-is :) -- Andrea Bolognani / Red Hat / Virtualization