Re: [libvirt] [PATCH] qemu: Double mutex unlock in qemuDomainModifyDeviceFlags

On Thu, Jan 17, 2013 at 18:25:28 +0100, Viktor Mihajlovski wrote: > The driver mutex was unlocked in qemuDomainModifyDeviceFlags before > entering qemuDomainObjBeginJobWithDriver where it will be unlocked once > more leaving it in an undefined state. The result was that two > threads were simultaneously looking up the domain hash table during > multiple parallel device attach/detach operations. > Luckily this triggered a virHashIterationError. > > Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com&gt; > ---

ACK. The function relies on driver being locked and unlocks it in cleanup phase.