Re: [libvirt] [libvirt-php] Add lookup function for pool & volume

Hi Lyre,

+ set_error ("Cannot find storage pool" TSRMLS_CC);

This is being set by the function itself and caught using the catch_error() so please avoid this line in v2 of the patch.

+ volume=virStorageVolLookupByPath (conn->conn,name); + if (volume==NULL) + { + set_error ("Cannot find volume"); + RETURN_FALSE; + }

Same here. Thanks, Michal -- Michal Novotny <minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat