Re: [libvirt] [PATCH] Sheepdog: Auto Adding volume and correct refresh volume problem. Resent file

On 01/27/2014 04:11 AM, joel SIMOES wrote: Your title says 'Re: ...', but there is no In-reply-to heading that states what you were replying to. Furthermore, including the text 'Resent file' in the subject line looks awkward when used as a git commit (look at 'git shortlog -30' for an idea of good subject lines, and note that none of them mention 'Resent file' in the text). If this is a second version of the patch, it is better to use 'git send-email --subject-prefix=PATCHv2' to make it clear that it is a resend, rather than munging the subject line by hand outside of the [] prefix. Also, your commit message body is still empty. Remember, the subject line should be brief (the WHAT), the commit message body before the --- should not be empty (the WHY), and the space after the --- is useful for reviewer's notes (HOW this differs from v1). This hunk is still spurious. I pointed it out last time, and it is rather annoying to review patches where items pointed out previously aren't addressed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org