Richard Laager wrote:
On 03/16/2016 03:26 AM, Roman Bogorodskiy wrote:
Actually, the primary question is: do we want to add extra logic on top of what ZFS does (i.e. disallow refres > volize, 'round' displayed allocation) or just make things simple and do and show whatever ZFS allows us to do and to show respectively.
I'm not necessarily sure I know the answer. So that probably argues for the simpler approach of libvirt just being a pass-through. Also, it's possible to add the extra code later, if that turns out to be better.
I've already submitted patches taking each approach. What do you think is the next step?
Hi Richard, I'm really sorry, I saw the updated patch and overall it looks good, but I haven't had time to look closer. I hope to do it this weekend and give it some testing on FreeBSD and push it if everything is fine. Roman Bogorodskiy