Re: [libvirt] [PATCH 4/4] qemu: Generate memory device aliases according to slot number

On 11/03/2016 02:12 AM, Peter Krempa wrote: > The memory device alias needs to be treated as machine ABI as qemu is > using it in the migration stream for section labels. To simplify this > generate the alias from the slot number unless an existing broken > configuration is detected. > > With this patch the aliases are predictable and even certain > configurations which would not be migratable previously are fixed. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1359135 > --- > src/qemu/qemu_alias.c | 27 ++++++++++++++++++---- > src/qemu/qemu_alias.h | 3 ++- > src/qemu/qemu_hotplug.c | 4 +++- > .../qemuxml2argv-memory-hotplug-dimm-addr.args | 4 ++-- > 4 files changed, 29 insertions(+), 9 deletions(-) > Revisiting after my face-palm for patch2. > diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c > index 9737158..8521a44 100644 > --- a/src/qemu/qemu_alias.c > +++ b/src/qemu/qemu_alias.c > @@ -332,17 +332,34 @@ qemuAssignDeviceRNGAlias(virDomainDefPtr def, > } > > > +/** > + * qemuAssignDeviceMemoryAlias: > + * @def: domain definition. Necessary only if @oldAlias is true. s/old/use (multiple places)