Re: [libvirt] [re-send][PATCH 2/3] use WIFEXITED macro to see exit status of child

9 Oct 2012

On 10/08/2012 07:51 PM, liguang wrote:
...
this usage was suggested by man-page of waitpid,
returns  true  if  the  child terminated normally
NACK.  virCommandRun already did this for you.
...
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 src/util/hooks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/hooks.c b/src/util/hooks.c
index f5890d2..55b98ca 100644
--- a/src/util/hooks.c
+++ b/src/util/hooks.c
@@ -280,7 +280,7 @@ virHookCall(int driver,
         virCommandSetOutputBuffer(cmd, output);
ret = virCommandRun(cmd, &exitstatus);
-    if (ret == 0 && exitstatus != 0) {
+    if (ret == 0 && WIFEXITED(exitstatus) == 0) {
         virReportError(VIR_ERR_HOOK_SCRIPT_FAILED,
                        _("Hook script %s %s failed with error code %d"),
                        path, drvstr, exitstatus);
-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

    