On Wed, May 13, 2009 at 05:24:33PM +0200, Daniel Veillard wrote:
On Wed, May 13, 2009 at 03:35:26PM +0100, Daniel P. Berrange wrote:
This provides the 2 public APIs needed for conversion of domain XML to/from native configuration formats. It also hooks up the internal driver infrastructure, and binds to virsh
[...]
+/* + * "domxml-from-native" command + */ +static const vshCmdInfo info_domxmlfromnative[] = { + {"help", gettext_noop("Import native config as domain XML")}, + {"desc", gettext_noop("Import native guest configuration format to domain XML format.")}, + {NULL, NULL} +};
I wouldn't really say it's an import, at best it's an export to a new format, import may be misunderstood as possibly defining a resulting domain.
+/* + * "domxml-to-native" command + */ +static const vshCmdInfo info_domxmltonative[] = { + {"help", gettext_noop("Export domain XML as native config")}, + {"desc", gettext_noop("Export domain XML config to a native guest configuration format.")}, + {NULL, NULL} +};
Hum, maybe we should just use "Convert" instead of import or export.
This is left over from a earlier version. I was calling the APIs and virsh commands domxml-import and domxml-export, but i decided this was confusing, to changed but forgot the help text. Convert is a better word for this Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|