Re: [libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

On Friday, 12 January 2018 12:38:01 CET Bjoern Walk wrote: > + while ((tmp_base = strstr(tmp_base, "cpu number")) && > + (tmp_base = virSysinfoParseS390Line(tmp_base, "cpu number", &ncpu))) { > + unsigned int n; > + char *mhz = NULL; > [...] > + if (n >= ret->nprocessor) { > + VIR_DEBUG("CPU number '%d' out of range", n); Since 'n' is unsigned int, then the right printf format is %u.

The rest of the patch seems good to me.

Thanks, -- Pino Toscano