Re: [libvirt] [PATCHv2] build: let autobuild check more code

On Thu, Dec 15, 2011 at 01:00:02PM -0700, Eric Blake wrote: > On 12/15/2011 01:49 AM, Daniel P. Berrange wrote: >> On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: >>> Many times, we don't notice a bug in src/libvirt_private.syms >>> until someone attempts a build with modules enabled. Likewise, >>> some gcc warnings about no % in a printf format string only >>> appear under --disable-nls. And configure.ac should automatically >>> be excluding modules on mingw without us having to be explicit. >>> Improving autobuild.sh to stress more combinations can only help. >>>

>> >> ACK > > Thanks for the review; however, I will defer pushing this patch until I > also have time to fix a couple of fallout problems (my goal is to get > this all squared away before 0.9.9). In particular, ./autobuild.sh now > fails with: Hmm, I presume this is due to the addition of '-with-driver-modules'. If so, please push the other bits of your patch, and leave the driver modules bit for later.