Re: [libvirt] [PATCHv3 3/7] vmx: convert to typesafe virConf accessors

8 Jun 2018

      On Mon, May 28, 2018 at 12:28:22AM +0200, Fabiano Fidêncio wrote:
...
Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
---
src/vmx/vmx.c | 194 +++++++++++++++++++++-------------------------------------
1 file changed, 70 insertions(+), 124 deletions(-)
-    if (virUUIDParse(value->str, uuid) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Could not parse UUID from string '%s'"), value->str);
-        return -1;
-    }
+    ret = 0;
-    return 0;
+  cleanup:
'make syntax-check' complains about two spaces in front of a label.

I will fix that before pushing.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
...
+    VIR_FREE(string);
+    return ret;
}