Re: [libvirt] [PATCH 01/10] Move QEMU capabilities management into a separate file

On 12/16/2010 09:50 AM, Daniel P. Berrange wrote: > The qemu_conf.c code is doing three jobs, driver config file > loading, QEMU capabilities management and QEMU command line > management. Move the capabilities code into its own file > > * src/qemu/qemu_capabilities.c, src/qemu/qemu_capabilities.h: New > capabilities management code > * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Delete capabilities > code > * src/qemu/qemu_conf.h: Adapt for API renames > * src/Makefile.am: add src/qemu/qemu_capabilities.c > --- > src/Makefile.am | 1 + > src/qemu/qemu_capabilities.c | 1253 ++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_capabilities.h | 113 ++++ > src/qemu/qemu_conf.c | 1191 +--------------------------------------- > src/qemu/qemu_conf.h | 81 --- > src/qemu/qemu_driver.c | 55 +-

Other than that nit, ACK - this appeared to be straight code motion plus fallout from renaming to a consistent API