On 02/19/2018 06:46 AM, Daniel P. Berrangé wrote:
It is very difficult while reading the migration code trying to understand whether a particular function is being called on the src side or the dst side, or either. Putting "Src" or "Dst" in the method names will make this much more obvious. "Any" is used in a few helpers which can be called from both sides.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> ---
Changed in v3:
- Made most naming suggestions from John.
src/qemu/qemu_driver.c | 194 +++---- src/qemu/qemu_migration.c | 1378 +++++++++++++++++++++++---------------------- src/qemu/qemu_migration.h | 264 +++++---- src/qemu/qemu_process.c | 20 +- tests/qemuxml2argvtest.c | 4 +- 5 files changed, 940 insertions(+), 920 deletions(-)
Reviewed-by: John Ferlan <jferlan@redhat.com> John