Re: [libvirt] [PATCH 05/17] virsh-pool: Update pool commands to use vshCommandOptStringReq

4 Feb 2013

On 01/31/13 06:22, Osier Yang wrote:
...
On 2013年01月22日 02:07, Peter Krempa wrote:
...
Rework most of option string retrievals to the new helper.
---
  tools/virsh-pool.c | 56
+++++++++++++++++++++++++-----------------------------
  1 file changed, 26 insertions(+), 30 deletions(-)

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index bc400a1..5a7c8dd 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
[...]
...
...
@@ -226,26 +226,28 @@ static const vshCmdOptDef opts_pool_X_as[] = {
      {.name = NULL}
  };
-static int vshBuildPoolXML(const vshCmd *cmd, const char **retname,
char **xml) {
-
+static int
+vshBuildPoolXML(vshControl *ctl,
+                const vshCmd *cmd,
+                const char **retname,
+                char **xml)
Okay, you change the style here. :-)
Yep, part of this hunk belongs to the patch before.
...
ACK
Thanks.

Peter

    