Re: [libvirt] [PATCH 2/2] libxl: fallback to lib probe if pkgconfig file not found
On Thu, 2018-09-20 at 08:30 +0200, Michal Privoznik wrote:
On 09/19/2018 08:59 PM, Jim Fehlig wrote:
> + dnl In Fedora <= 28, the xenlight pkgconfig file is in the
> -runtime package
> + dnl https://bugzilla.redhat.com/show_bug.cgi?id=1629643
> + dnl Until Fedora 28 reaches EOL, fallback to lib probe if
> xenlight.pc is
> + dnl not found
Le sigh. So we have to have this in for next what 6 months? :-(
We're just re-introducing code that was recently removed with
5bdcef13d135: before that, it had been there for a very long time,
so six-ish more months are hardly going to make a difference.
<rant>
Sure, we can try working around broken packaging, or we can be
brave
and just tell users to install yet another package if they want to
have
xl driver enabled simply because they are using broken package. It's
not
our bug, and we already work around plenty of other bugs for other
apps/libs.
</rant>
We'd have to add something like
%if %{with_libxl} && 0%{?fedora} < 29
BuildRequires: xen-runtime
%endif
to libvirt.spec for that to work, and at that point you're just
exchanging one workaround for another... Might as well go for the
one that doesn't require users and CI workers to install extra
packages.
--
Andrea Bolognani / Red Hat / Virtualization