Re: [libvirt] [PATCHv4 01/18] blockjob: add qemu capabilities related to block jobs

On 04/09/2012 11:52 PM, Eric Blake wrote: > The new block copy storage migration sequence requires both the > 'drive-mirror' action in 'transaction' (present if the 'drive-mirror' > standalone monitor command also exists) and the 'drive-reopen' monitor > command (it would be nice if that were also part of a 'transaction', > but the initial qemu implementation has it standalone only). > > Furthermore, qemu 1.1 will be adding 'block_job_cancel' as an > asynchronous command, but an earlier implementation (that supported > only the qed file format) existed which was synchronous only. If > 'drive-mirror' is added in time, then we can safely use 'drive-mirror' > as the witness of whether 'block_job_cancel' is synchronous or > asynchronous. > > As of this[1] qemu email, both commands have been proposed but not yet > incorporated into the tree; in fact, the implementation I tested with > has changed to match this[2] email that suggested a mandatory > 'full':'bool' argument rather than 'mode':'no-backing-file'. So there > is a risk that qemu 1.1 will have yet another subtly different > implementation. > [1]https://lists.gnu.org/archive/html/qemu-devel/2012-03/msg01524.html > [2]https://lists.gnu.org/archive/html/qemu-devel/2012-04/msg00886.html None of this gives me warm fuzzies :-/