Re: [libvirt] [PATCH v2 04/15] qemu: Restrict scope in qemuBuildControllerDevStr()
On Mon, 2018-02-19 at 16:00 +0100, Peter Krempa wrote:
> @@ -2625,8 +2625,6 @@ qemuBuildControllerDevStr(const
virDomainDef *domainDef,
> {
> virBuffer buf = VIR_BUFFER_INITIALIZER;
> int address_type = def->info.type;
> - const virDomainPCIControllerOpts *pciopts;
> - const char *modelName = NULL;
>
> *devstr = NULL;
Since the next patch changes both lines again I suggest you squash it
into the next patch.
They're semantically independent changes so I thought it would be
better to perform them separately, but I can squash them together
if that's your preference.
--
Andrea Bolognani / Red Hat / Virtualization