20 Feb
2008
20 Feb
'08
11:17 a.m.
On Wed, 2008-02-20 at 16:42 +0100, Jim Meyering wrote:
If I do as you suggest and move the safewrite definition into util.h, and make it static inline, then both problems go away.
Make sure to try and build this with gcc-4.3.0 - remember that we un-inlined xstrtol() because of: internal.h:272: error: inlining failed in call to 'xstrtol_i': call is unlikely and code size would grow Again, the option is to stop using -Winline, but it's probably about time we figured out some proper way of sharing code between libvirt.so and virsh etc. without adding it to the ABI. How about a libvirtutil libtool convenience (i.e. static) library? Cheers, Mark.