Re: [libvirt] [PATCH] storage: fix memory leak with encrypted images

Eric Blake wrote: > Jim Fehlig reported a regression found by libvirt-TCK tests: >

> Commit 2279d560 converted a boolean into a pointer with the intent of > transferring that pointer out of a temporary object into the caller's > data structure. The temporary structure meant that meta->encryption > was always NULL on entry, so we could get away with blindly allocating > the pointer when the header said so. But later commits then tweaked > things to do backing chain detection in-place, rather than via a > temporary object; this has the net result that meta->encryption can be > non-NULL on entry. For reference, bisected and found the 'later commit' you mentioned to be commit 8823272d41a259c1246c05d89f40ad3614fba58c

ACK.