Re: [libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

On 09/17/2013 09:56 AM, hzguanqiang(a)gmail.com wrote: Closer. This time, your cover letter lists: Message-id: <52387bc4.8223440a.6e6a.163b(a)mx.google.com&gt; which is valid; but your patches list: References: <1379433398-21795-1-git-send-email-y> In-Reply-To: <1379433398-21795-1-git-send-email-y> which is still not a valid email reference (according to the RFCs, References: and In-Reply-To: fields should contain an @), and therefore are not threaded to the cover letter. Note how confused the list archiver got when trying to decipher your mail: https://www.redhat.com/archives/libvir-list/2013-September/thread.html#01007 For an example of threading done right, see: https://www.redhat.com/archives/libvir-list/2013-September/thread.html#00982 There, the cover letter uses: Message-id: <cover.1379428840.git.mprivozn(a)redhat.com&gt; and each patch contains: References: <cover.1379428840.git.mprivozn(a)redhat.com&gt; In-Reply-To: <cover.1379428840.git.mprivozn(a)redhat.com&gt; When working on git mail configurations, it is often a good idea to use 'git send-email --to=YOUR@EMAIL' and send the patches to yourself first, to check if you have properly configured git, before sending to the list. At any rate, please don't resend just because of this (3 attempts is enough for one day; the patches are available, even if we have to hunt a bit for them); just remember it for you next future patch submission :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org