On 01/21/2010 11:49 AM, Jamie Strandboge wrote:
Was this patch tested? I initially tried to use virFileResolveLink() but could not. This was discussed in "[libvirt] [PATCH 0/4] AppArmor updates" from 11/12/2009:
"Implements all changes requested by DV except for getting rid of readlink(). I can't use virFileResolveLink() because it lstat()s the file and uses st.st_size to create a buffer. Unfortunately, running lstat() on /proc/self/exe results in st.st_size to be 0."
Unless virFileResolveLink() was changed, this patch will break AppArmor.
Jamie
Ah, I should have mentioned that. I only compile tested it. However, virFileResolveLink() was indeed changed to use gnulib's areadlink() function instead of the previous lstat()/readlink(), so it may work now. Do you have a test environment to test it out quickly? -- Chris Lalancette