Re: [libvirt] [PATCH] tests: Add QEMU 2.10.0 capabilities test for s390x
On 09/21/2017 09:35 PM, John Ferlan wrote:
On 09/19/2017 10:06 AM, Boris Fiuczynski wrote:
> Adding s390x qemu caps test for qemu version 2.10.0.
>
> Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
> ---
> .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 16441 +++++++++++++++++++
> tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 316 +
> tests/qemucapabilitiestest.c | 1 +
> 3 files changed, 16758 insertions(+)
> create mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.s390x.replies
> create mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
>
I made one minor adjustment to add the vxhs flag only because that got
pushed before you created this and it caused failure otherwise.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
(and pushed)
John
also avoiding the list moderation on a v2 for just that ;-)
John,
thanks for reviewing the patch. To me it seems the vxhs flag patch was
pushed to master after I send my patch to the mailing list. But at the
end it does not matter since the adjustment needed and has been done.
Thank you for catching and adjusting it!
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294