Re: [libvirt] [PATCH v3 10/20] nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr

On 06/14/2018 08:32 AM, Daniel P. Berrangé wrote:

Use the virNWFilterBindingDefPtr struct in the gentech driver code directly.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/nwfilter/nwfilter_dhcpsnoop.c | 39 ++-- src/nwfilter/nwfilter_driver.c | 24 ++- src/nwfilter/nwfilter_gentech_driver.c | 236 ++++++++++++------------- src/nwfilter/nwfilter_gentech_driver.h | 22 ++- src/nwfilter/nwfilter_learnipaddr.c | 18 +- 5 files changed, 175 insertions(+), 164 deletions(-)

FWIW: existing, but virNWFilterDoInstantiate doesn't have a complete list of parameters in the method doc... Missing ifindex, useNewFilter, foundNewFilter, teardownOld, and driver. Reviewed-by: John Ferlan <jferlan@redhat.com> John