On Fri, May 05, 2023 at 01:37:59PM +0200, Martin Kletzander wrote:
On Tue, May 02, 2023 at 07:15:52PM +0200, Andrea Bolognani wrote:
> initconfdir = get_option('initconfdir')
> if initconfdir == ''
> - initconfdir = sysconfdir / 'sysconfig'
> + if (os_release.contains('alpine') or
> + os_release.contains('arch') or
> + os_release.contains('gentoo'))
I can't vouch for all of these, but from my limited memory and
search-engine-fu I think you're right here. There might be more and
more caveats when migrated to systemd for example, especially with
custom envvar files, but that's beside the point here.
I've just looked at what the official package in each distribution is
doing:
https://git.alpinelinux.org/aports/tree/community/libvirt/APKBUILD#n131
https://github.com/archlinux/svntogit-community/blob/packages/libvirt/tru...
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-emulation/libvirt/file...
https://salsa.debian.org/libvirt-team/libvirt/-/blob/debian/latest/debian...
We can always tweak things later, of course.
Thanks for the review! I'll push the patches now :)
--
Andrea Bolognani / Red Hat / Virtualization