Re: [libvirt] [PATCH] perf: introduce option --reset

On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(virDomainPtr dom, > if (def) { > for (i = 0; i < nparams; i++) { > virTypedParameterPtr param = &params[i]; > - enabled = param->value.b; > + state = param->value.i; NACK, this semantic change is not backwards compatible - this will break all applications & language bindings currently using libvirt perf events. Oh I see . I didn't realize that. Any other API/place you suggest, through

In addition "reset" is not really a state - "enabled" / "disabled" are stats - 'reset' is an action that is applied to an existing state. So modelling 'reset' as a state is wrong too IMHO. Regards, Daniel

-- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|