Re: [libvirt] [PATCH 2/8] Revert "qemu: hotplug: consolidate media change code paths"

On 9/27/18 11:09 AM, Peter Krempa wrote:

While the idea was good the implementation not so much as we need to take into account the old disk data and the new source. The code will be consolidated later in a different way.

This reverts commit 663b1d55de652201b19d875f0eff730dc28e689e.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/qemu/qemu_driver.c | 20 ++++++++++++++++++-- src/qemu/qemu_hotplug.c | 18 +++--------------- src/qemu/qemu_hotplug.h | 9 +++++++-- tests/qemuhotplugtest.c | 2 +- 4 files changed, 29 insertions(+), 20 deletions(-)

Reviewed-by: John Ferlan <jferlan@redhat.com> John