Re: [libvirt] [jenkins-ci POC 2/2] guests: Add Dockerfile generator
On Fri, Jun 15, 2018 at 08:53:44AM +0200, Andrea Bolognani wrote:
This is basically the exact same algorithm used by the
Ansible playbooks to process package mappings, implemented
as a standalone script.
There's little to none error handling, and some information
is hardcoded instead of being configurable at runtime; more
importantly, before it can be considered for merging it
needs to be integrated into lcitool, which in turn requires
lcitool to be significantly reworked.
I'm not understanding why it needs to be integrated into
lcitool ? Generating dockerfiles has no dependancy /
interaction with ansible updating the jenkins slaves.
Why won't we just run this script separately when needed,
ideally as non-root ? Looks good enough to commit now
IMHO
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|