Re: [libvirt] [PATCH v3 4/8] util: add virDiskNameParse to handle disk and partition idx

On 11/13/2015 06:14 AM, Joao Martins wrote:

Introduce a new helper function "virDiskNameParse" which extends virDiskNameToIndex but handling both disk index and partition index. Also rework virDiskNameToIndex to be based on virDiskNameParse. A test is also added for this function testing both valid and invalid disk names.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com> --- Changes since v2: - Sort the newly added symbol in the list --- src/libvirt_private.syms | 1 + src/util/virutil.c | 41 +++++++++++++++++++++++++++++++---- src/util/virutil.h | 1 + tests/utiltest.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 95 insertions(+), 4 deletions(-)

ACK; pushed. Thanks! Regards, Jim