Re: [libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections
On 25-08-2010 18:07, Daniel P. Berrange wrote:
> --- a/src/uml/uml_driver.c
> +++ b/src/uml/uml_driver.c
> @@ -373,6 +373,10 @@ umlStartup(int privileged) {
>
> if ((base = strdup (SYSCONF_DIR "/libvirt")) == NULL)
> goto out_of_memory;
> +
> + if (virAsprintf(¨_driver->monitorDir,
> + "%s/run/libvirt/uml", LOCAL_STATE_DIR) == -1)
> + goto out_of_memory;
Can we make this '%s/lib/libvirt/uml'
You want transient stuff like UNIX sockets in /var/lib? That seems odd
to me.
The FHS even explicitly says: "System programs that maintain transient
UNIX-domain sockets must place them in this directory." where "this
directory" is /var/run.
> } else {
>
> if (virAsprintf(¨_driver->logDir,
> @@ -381,11 +385,11 @@ umlStartup(int privileged) {
>
> if (virAsprintf(&base, "%s/.libvirt", userdir) == -1)
> goto out_of_memory;
> - }
>
> - if (virAsprintf(¨_driver->monitorDir,
> - "%s/.uml", userdir) == -1)
> - goto out_of_memory;
> + if (virAsprintf(¨_driver->monitorDir,
> + "%s/.uml", userdir) == -1)
> + goto out_of_memory;
> + }
And '%s/.libvirt/uml/lib'
I understand your desire to be consistent, but I really think
integrating well with existing management tools for the hypervisor (in
this case uml-utilities) is more important.
--
Soren Hansen
Ubuntu Developer
http://www.ubuntu.com/