Re: [libvirt] [PATCH 4/7] Introduce vircommandpriv.h for functions used by tests

On Wed, Mar 12, 2014 at 02:08:14PM +0100, Ján Tomko wrote: > So far it's just virCommandSetDryRun. > --- > src/Makefile.am | 2 +- > src/util/vircommand.c | 2 +- > src/util/vircommand.h | 2 -- > src/util/vircommandpriv.h | 28 ++++++++++++++++++++++++++++ > tests/virkmodtest.c | 2 +- > tests/virnetdevbandwidthtest.c | 2 +- > 6 files changed, 32 insertions(+), 6 deletions(-) > create mode 100644 src/util/vircommandpriv.h

Also add in #ifndef __VIR_COMMAND_PRIV_H_ALLOW__ # error "vircommandpriv.h may only be included by vircommand.c or test suites" #endif and then make vircommand.c and any relevant test suites #define this symbol before including the file. > +#ifndef __VIR_COMMAND_PRIV_H__ > +# define __VIR_COMMAND_PRIV_H__ > + > +# include "vircommand.h" > + > +void virCommandSetDryRun(virBufferPtr buf); > +#endif /* __VIR_COMMAND_PRIV_H__ */ ACK with that change.