Re: [libvirt] [PATCH 7/8] Avoid unsafe use of /proc/$PID/root in LXC chardev hostdev hotplug

On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:

Rewrite lxcDomainAttachDeviceHostdevMisceLive function

s/Misce/Misc/

to use the virProcessRunInMountNamespace helper. This avoids risk of a malicious guest replacing /dev with a absolute symlink, tricking the driver into changing the host OS filesystem.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_driver.c | 66 ++++++++++++++-------------------------------------- 1 file changed, 18 insertions(+), 48 deletions(-)

ACK -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org