Re: [libvirt] [PATCH 09/10] Implement virsh qemu-monitor-command.
On 04/21/2010 10:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
---
tools/Makefile.am | 1 +
tools/virsh.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++
Nothing in tools/virsh.pod? Hmm, we ought to modify docs/api_extension
to mention documenting new virsh commands (step 8/8).
+ if (virDomainQemuMonitorCommand(dom, monitor_cmd, &result,
0) < 0)
+ goto cleanup;
+
+ fprintf(stdout, "%s\n", result);
Isn't puts(result) more efficient, for the same end result?
To help keep docs in sync, I'll withhold an ack until seeing the .pod
updates in the respin :)
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)