Re: [libvirt] [PATCHv2] libvirt: add daemon itself as shutdown reason
On Wed, Nov 14, 2018 at 05:19:35PM +0100, Andrea Bolognani wrote:
On Tue, 2018-11-13 at 15:36 -0500, John Ferlan wrote:
> From: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com>
>
> This patch introduces a new shutdown reason "daemon" in order
> to indicate that the daemon needed to force shutdown the domain
> as the best course of action to take at the moment.
>
> This action would occur during reconnection when processing
> encounters an error once the monitor reconnection is successful.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com>
> Reviewed-by: John Ferlan <jferlan(a)redhat.com>
This made language bindings sad:
https://ci.centos.org/view/libvirt/job/libvirt-go-check/106/
https://ci.centos.org/view/libvirt/job/libvirt-perl-check/107/
This is normal - the check jobs are explicitly intended to fail
whenever public API additions are made to remind us (me) to add
support there.
Interestingly, Python doesn't seem to be bothered at all.
python auto-generates some of its code.
Anyway, it would be great if someone would add support for the new
enum value to Go and Perl bindings and make CI happy again :)
I'm doing it..
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|