Re: [libvirt] [PATCH] Support the usage of socat instead of netcat
On Thu, Aug 06, 2009 at 12:39:34PM +0100, Daniel P. Berrange wrote:
On Wed, Aug 05, 2009 at 12:58:33PM +0200, Jonas Eriksson wrote:
> * src/remote_internal.c: Honour USE_SOCAT by selecting between
> netcat/nc and socat at compile time.
Changing the binary used at compile time is really not a good idea,
because libvirt uses netcat on the remote machine, which is not
required to be the same distro as the client machine on whihc you
built libvirt. So by making socat vs netcat a compile time option
you pretty much guarentee incompatibility between libvirt client &
server betweeen distros. It is really better to fix netcat on the
distros where -U isn't available.
As for other case where we had multiple binary options, isn't
picking up at runtime a possibility, suppose we can catch that
'netcat -U' fails, we could try to fallback to socat.
In any case a compile time switch doesn't sounds right to me but
being more flexible at runtime is similar to the way we have done
for dependance on other binaries.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/