Re: [Libvir] [RFC] Linux-VServer support

Daniel P. Berrange wrote: >On Tue, Oct 30, 2007 at 04:28:59PM +0100, Daniel Hokka Zakrisson wrote: >>This is an initial stab at adding Linux-VServer support to libvirt. >>There are still a couple of things missing, like scheduler support in >>the XML parsing, and proper network support. > >Great to see interest in adding more drivers ! I've not had time to look >at your patch in great detail yet, but I'll give some more detailed >feedback in the next day or so. My first comment though - why the ><xid>123</xid> field in the XML - the unique integer ID for a domain >should really be in the 'id' attribute <domain id='123'>. There are a >couple of other small XML format consistency issues like that to check >up on. Yeah, the only reason I did it with a separate element was that I really don't know XPath, so I hadn't figured out how to get the id in that case.