Re: [libvirt] [PATCH] Fix typos in src/*
On 04/21/2014 05:13 PM, Nehal J Wani wrote:
On Tue, Apr 22, 2014 at 4:19 AM, Eric Blake <eblake(a)redhat.com>
wrote:
> On 04/20/2014 02:07 PM, Nehal J Wani wrote:
>> Fix minor typos in source comments
>>
>> ---
>
> Thanks for doing this! Any particular tool you used for finding these?
Thanks for the review.
Well, not exactly a tool, but I had a list of most common misspellings
(scraped from Wikipedia, etc) and then in the source tree:
for i in `cat /tmp/bad_words | awk '{print $1}'` ; do echo " $i ";
grep " $i " -r ./* ; done
I deliberately didn't touch the errors in news.html.in because it
directly copies the commit messages. So, if we have a spell error in
the git log and the same is not present in this file, I thought maybe
inconsistency issues will arise.
Oh well; if someone regenerates news.html.in it will revert to the wrong
spellings. Gnulib has a feature called 'gitlog-to-changelog' which also
has the option of providing fixups for typos in commit messages
(basically a text file of replacement rules to apply to overcome bad
commit contents); if news.html.in were generated from the touched up
changelog instead of directly from git history, we'd have both nicer
looking news and no risk of typos being reintroduced. But that can be a
project for another day. DV is currently the one that generates
news.html.in additions, and I'm not sure what his process is.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)