Daniel Veillard wrote:
On Mon, Sep 24, 2007 at 11:29:07PM -0400, beth kon wrote:
[PATCH 1/2] - add capability to access free memory information on each NUMA cell.
Signed-off-by: Beth Kon (eak@us.ibm.com)
-- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak@us.ibm.com
diff -urpN libvirt.danielpatch/include/libvirt/libvirt.h.in libvirt.cellsMemory/include/libvirt/libvirt.h.in --- libvirt.danielpatch/include/libvirt/libvirt.h.in 2007-09-11 15:29:43.000000000 -0400 +++ libvirt.cellsMemory/include/libvirt/libvirt.h.in 2007-09-20 14:11:32.000000000 -0400 @@ -586,8 +586,9 @@ int virDomainDetachDevice(virDomainPtr d */
int virNodeGetCellsFreeMemory(virConnectPtr conn, - unsigned long *freeMems, - int nbCells); + long long *freeMems, + int startCell, + int maxCells);
Hum, I just realize something, shouldn't we use unsigned long long *freeMems instead. I don't see what semantic a negative value can carry, but maybe I missed something !
Daniel
Yes, I agree. I'll change that. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak@us.ibm.com