Re: [PATCH RFC v3 05/16] qemu: monitor: Add support for ThrottleGroup operations
let me confirm my understanding, do you mean there should be group name
mapping between DOM($group_name_in_DOM) and
QOM(throttle-$group_name_in_DOM) for both throttle group and throttle
filter? if so, there seems two ways to achieve that:
- mapping group_name in callers like qemu_driver.c, qemu_hotplug.c,
qemu_command.c
- or put all mappings only into qemu_monitor.c/qemu_monitor_json.c, in
this way, I may need to expose more methods within monitor to prepare
virJSONValueObject for ThrottleGroup and ThrottleFilter creation, it
seems this way can centralize mapping logic within monitor only
On 2024/7/26 21:58, Peter Krempa wrote:
Note that since all objects live in one namespace in qemu you'll
have to
add a prefix to the group name so that the user will not be able to
accidentaly pick a group name (which would be equivalent with the object
'id') which we might either be using or introduce in the future.
Add a 'throttle-' prefix so that we clearly separate the throttle group
objects into their own namespace.
This will need to be done everywhere where you pass the throttle group
name as object name to qemu.
--
Thanks and Regards,
Wu
Attachments:
- attachment.html (text/html — 1.5 KB)