Re: [libvirt] [PATCH v3 0/2] selinux: Only create the selabel_handle once.
On Thu, Jan 24, 2013 at 10:10:56AM +0000, Richard W.M. Jones wrote:
Version 3 of this patch. Because I now have to pass the
'mgr' pointer
around, the patch is considerably more complicated than before.
Patch 1/2 is required so that I can use virReportSystemError when I
don't need to have any optional arguments, ie. the equivalent of:
printf ("foo\n");
No, that's not allowed - everything must have a format string - even
static messages - it should instead be:
printf ("%s", _("foo\n"));
make syntax-check ought to have complained about this IIRC.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|