Re: [libvirt] [PATCH 03/10] tests: qemumonitor: Simplify handling of end of file in full file test
On 06/04/2018 09:58 AM, Peter Krempa wrote:
On EOF, the loop can be terminated right away since most of it is
skipped anyways and the handling of the last command is repeated after
the loop.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
tests/qemumonitortestutils.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
Would this be more readable with virStringSplit[Count] ? Every time I
see strchr, that's where I go...
What's here is fine, but figured I'd ask anyway.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John