On 07/21/2011 06:30 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange@redhat.com>
There is some commonality between the code for sanity checking certs when initializing libvirt and the code for validating certs during a live TLS session handshake. This patchset splits up the sanity checking function into several smaller functions each doing a specific type of check. The cert validation code is then updated to also call into these functions
* src/rpc/virnettlscontext.c: Refactor cert validation code --- src/rpc/virnettlscontext.c | 466 +++++++++++++++++++++++++++----------------- 1 files changed, 283 insertions(+), 183 deletions(-)
ACK - not the easiest diff to follow, but does make sense for smaller self-contained functions and building up validation out of common pieces. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org