Re: [libvirt] [PATCH] always compile iptables.c
On Fri, Nov 07, 2008 at 02:49:43PM +0100, Jim Meyering wrote:
This is slightly different from the previous version.
The new part is the addition of the virRun stub to prevent
a mingw link failure when building with shared libraries.
Now, configured like this, it builds without error:
/usr/bin/mingw32-configure --without-sasl --without-avahi \
--without-polkit --without-python --without-xen --without-qemu \
--without-lxc --without-openvz --without-libvirtd \
--prefix=/tmp/libvirt-inst --enable-compile-warnings=maximum
OK, looks good to me, +1.
On an unrelated point, probably any usage of __MINGW32__ is suspect, eg:
#else /* __MINGW32__ */
Our MinGW cross-compiler defines the symbol 'WIN32', and so do all
compilers on Windows itself[1][2].
Therefore it's better to use #ifdef WIN32 ... #endif for any code that
is specific to the Win32 API.
The __MINGW32__ symbol has a place for code which is specific to the
MinGW version of GCC, eg. if it had a bug that we needed to work
around.
The attached patch appears to work with some light testing.
Rich.
[1] Even for 64-bit code.
[2] The exception is Cygwin, but you can argue that Cygwin is really a
Unix API.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Attachments:
- libvirt-no-mingw32.patch (text/plain — 3.0 KB)