On 07/15/2014 03:38 PM, Michal Privoznik wrote:
On 15.07.2014 14:58, Ján Tomko wrote:
> On 07/15/2014 02:38 PM, Michal Privoznik wrote:
> IMO we should set n<elems> to 0 in all *Clear functions, not just
> virNetworkDNSHostDefClear, after which NULL might be dereferenced based on the
> n<elems> variable.
I don't see how that could be possible with current code. The
virNetworkDNSHostDefClear is called only on cleanup paths where accessing
def->names or def->forwarders is not possible anymore.
In virNetworkDefUpdateDNSHost when parsing in virNetworkDNSHostDefParseXML
fails, DNSHostDefClear is called in both functions.
Jan