This is a code repetition that I crossed a few times, then
I noticed that Cole Robinson suggested a solution for it
in the wiki. Here it is.
changes from v2:
- use a boolean to determine 'QEMU' and 'vbox' case to avoid block
repetition (patch 8)
- avoid 80+ chars lines in all patches
changes from v1:
- handle QEMU and vbox cases separately inside the validation
function
v2:
https://www.redhat.com/archives/libvir-list/2019-September/msg01007.html
v1:
https://www.redhat.com/archives/libvir-list/2019-September/msg00983.html
Daniel Henrique Barboza (11):
src/driver.c: add virConnectValidateURIPath()
interface_backend_netcf.c: use virConnectValidateURIPath()
interface_backend_udev.c: use virConnectValidateURIPath()
bridge_driver.c: virConnectValidateURIPath()
node_device_driver.c: use virConnectValidateURIPath()
secret_driver.c: use virConnectValidateURIPath()
storage_driver.c: use virConnectValidateURIPath()
driver.c: change URI validation to handle QEMU and vbox case
qemu_driver.c: use virConnectValidateURIPath()
vbox_common.c: use virConnectValidateURIPath()
vbox_driver.c: use virConnectValidateURIPath()
src/driver.c | 38 +++++++++++++++++++++++++
src/driver.h | 4 +++
src/interface/interface_backend_netcf.c | 19 +++----------
src/interface/interface_backend_udev.c | 19 +++----------
src/libvirt_private.syms | 1 +
src/network/bridge_driver.c | 19 +++----------
src/node_device/node_device_driver.c | 19 +++----------
src/qemu/qemu_driver.c | 20 +++----------
src/secret/secret_driver.c | 19 +++----------
src/storage/storage_driver.c | 19 +++----------
src/vbox/vbox_common.c | 16 ++---------
src/vbox/vbox_driver.c | 16 ++---------
12 files changed, 75 insertions(+), 134 deletions(-)
--
2.21.0