Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model
On Mon, Jan 10, 2011 at 10:44:29AM -0700, Eric Blake wrote:
On 01/10/2011 10:19 AM, Cole Robinson wrote:
> In QEMU, the card itself is a PCI device, but it requires
> -device hda-output in order to actually get sound to the host. AIUI this
> is just HDA configuration and does not require stable addressing, so
> is not presently represented in the XML.
>
> Additionally, qemu supports audio input with '-device hda-duplex', however
> that provides guests access to the host's microphone, so probably isn't
> what we want by default.
Is there room for future XML expansion if we do decide to expose the
choice between -device hda-output vs. -device hda-duplex via the XML?
The patch looks fine as-is, but I'm a bit hesitant to ack until we've
thought about a potential upgrade path for the future, in case it
implies rearranging any of this patch.
That isn't related to the device model name, so I think it is fine.
hda-output vs hda-duplex is basically determining whether QEMU
can merely write to the sound card (to play audio), or can also
read from the card (to record via the mic). This is something
we'd want to represent either as additional attributes, or child
elements.
Regards,
Daniel